]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
usb: misc: brcmstb-usb-pinmap: Fix an IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 2 Nov 2020 07:56:55 +0000 (10:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Nov 2020 09:09:23 +0000 (10:09 +0100)
The devm_ioremap() function doesn't return error pointers, it returns
NULL on error.

Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201102075655.GA4163205@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/brcmstb-usb-pinmap.c

index 02144c39aaba07e2a50a420144bd4b2348022d57..2326e60545f7fdfedb1a0f1e94761728ab6ae316 100644 (file)
@@ -277,8 +277,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)
        pdata->out_pins = (struct out_pin *)(pdata->in_pins + in_count);
 
        pdata->regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));
-       if (IS_ERR(pdata->regs))
-               return PTR_ERR(pdata->regs);
+       if (!pdata->regs)
+               return -ENOMEM;
        platform_set_drvdata(pdev, pdata);
 
        err = parse_pins(&pdev->dev, dn, pdata);