]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ALSA: hda: cs35l41: Make use of the helper function dev_err_probe()
authorLucas Tanure <tanureal@opensource.cirrus.com>
Mon, 17 Jan 2022 16:08:29 +0000 (16:08 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 10:00:05 +0000 (12:00 +0200)
BugLink: https://bugs.launchpad.net/bugs/1965496
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220117160830.709403-5-tanureal@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit a025df02ce424fa77f6bc6aa195db21677e11274)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Acked-by: Andrea Righi <andrea.righi@canonical.com>
Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
sound/pci/hda/cs35l41_hda.c

index 82f982f574a920c0ffb05e0d56437913be67697f..c317b392c3e3887f86d10b6be8601a9497124635 100644 (file)
@@ -429,8 +429,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
                if (ret == -EBUSY) {
                        dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n");
                } else {
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(cs35l41->dev, "Failed to get reset GPIO: %d\n", ret);
+                       dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret);
                        goto err;
                }
        }