]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ARM: dts: armada388-helios4: assign pinctrl to LEDs
authorRosen Penev <rosenp@gmail.com>
Thu, 3 Dec 2020 02:23:20 +0000 (18:23 -0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Apr 2021 16:31:23 +0000 (18:31 +0200)
BugLink: https://bugs.launchpad.net/bugs/1918974
[ Upstream commit e011c9025a4691b5c734029577a920bd6c320994 ]

Split up the pins to match earlier definitions. Allows LEDs to flash
properly.

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/arm/boot/dts/armada-388-helios4.dts

index 705adfa8c680f6172f9927dca945c717f662cf05..e0fa1391948c1ea031ee083a8cd16e7b90b70bd3 100644 (file)
@@ -70,6 +70,9 @@
 
        system-leds {
                compatible = "gpio-leds";
+               pinctrl-names = "default";
+               pinctrl-0 = <&helios_system_led_pins>;
+
                status-led {
                        label = "helios4:green:status";
                        gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
@@ -86,6 +89,9 @@
 
        io-leds {
                compatible = "gpio-leds";
+               pinctrl-names = "default";
+               pinctrl-0 = <&helios_io_led_pins>;
+
                sata1-led {
                        label = "helios4:green:ata1";
                        gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
                                                       "mpp39", "mpp40";
                                        marvell,function = "sd0";
                                };
-                               helios_led_pins: helios-led-pins {
-                                       marvell,pins = "mpp24", "mpp25",
-                                                      "mpp49", "mpp50",
+                               helios_system_led_pins: helios-system-led-pins {
+                                       marvell,pins = "mpp24", "mpp25";
+                                       marvell,function = "gpio";
+                               };
+                               helios_io_led_pins: helios-io-led-pins {
+                                       marvell,pins = "mpp49", "mpp50",
                                                       "mpp52", "mpp53",
                                                       "mpp54";
                                        marvell,function = "gpio";