]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
net: ieee802154: forbid monitor for del llsec dev
authorAlexander Aring <aahringo@redhat.com>
Mon, 5 Apr 2021 00:30:47 +0000 (20:30 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 4 May 2021 14:13:31 +0000 (16:13 +0200)
BugLink: https://bugs.launchpad.net/bugs/1926493
[ Upstream commit ad8f9de1f3566686af35b1c6b43240726541da61 ]

This patch forbids to del llsec dev for monitor interfaces which we
don't support yet. Otherwise we will access llsec mib which isn't
initialized for monitors.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210405003054.256017-9-aahringo@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/ieee802154/nl802154.c

index 797888b4b2cefbf0df3b5f3eedfaea9d51a1e8e2..4f6777193029adf1924bd89886c6b4945c08e4e4 100644 (file)
@@ -1802,6 +1802,9 @@ static int nl802154_del_llsec_dev(struct sk_buff *skb, struct genl_info *info)
        struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1];
        __le64 extended_addr;
 
+       if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)
+               return -EOPNOTSUPP;
+
        if (!info->attrs[NL802154_ATTR_SEC_DEVICE] ||
            nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack))
                return -EINVAL;