]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
PM / Hibernate: Fix ioctl SNAPSHOT_S2RAM
authorRafael J. Wysocki <rjw@sisk.pl>
Tue, 10 May 2011 19:10:13 +0000 (21:10 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Wed, 11 May 2011 19:10:58 +0000 (21:10 +0200)
The SNAPSHOT_S2RAM ioctl used for implementing the feature allowing
one to suspend to RAM after creating a hibernation image is currently
broken, because it doesn't clear the "ready" flag in the struct
snapshot_data object handled by it.  As a result, the
SNAPSHOT_UNFREEZE doesn't work correctly after SNAPSHOT_S2RAM has
returned and the user space hibernate task cannot thaw the other
processes as appropriate.  Make SNAPSHOT_S2RAM clear data->ready
to fix this problem.

Tested-by: Alexandre Felipe Muller de Souza <alexandrefm@mandriva.com.br>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: stable@kernel.org
kernel/power/user.c

index 6522be913ac1b1ae5b3e7f89cfad2c137f1b399a..7d02d33be699f97d4956c76ea71b939bb0832d06 100644 (file)
@@ -381,6 +381,7 @@ static long snapshot_ioctl(struct file *filp, unsigned int cmd,
                 * PM_HIBERNATION_PREPARE
                 */
                error = suspend_devices_and_enter(PM_SUSPEND_MEM);
+               data->ready = 0;
                break;
 
        case SNAPSHOT_PLATFORM_SUPPORT: