]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drivers/net/wireless/wl12xx: Use available error codes
authorJulia Lawall <julia@diku.dk>
Mon, 16 Aug 2010 16:27:30 +0000 (18:27 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 24 Aug 2010 20:28:06 +0000 (16:28 -0400)
Error codes are stored in ret, but the return value is always 0.  Return
ret instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1271_acx.c

index bb245f05af496a2535ea5324b4113f4d499a4628..f03ad088db8b3eb7535e9e29de8b19dd08a0928d 100644 (file)
@@ -269,7 +269,7 @@ int wl1271_acx_pd_threshold(struct wl1271 *wl)
 
 out:
        kfree(pd);
-       return 0;
+       return ret;
 }
 
 int wl1271_acx_slot(struct wl1271 *wl, enum acx_slot_type slot_time)