]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
spi: s3c64xx: fix inconsistency between binding and driver
authorAndi Shyti <andi.shyti@samsung.com>
Fri, 10 Feb 2017 02:20:19 +0000 (11:20 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 13 Feb 2017 18:47:38 +0000 (18:47 +0000)
Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS
line is not connected") introduced an inconsistency between the
binding, where the disconnected CS line was marked as
'no-cs-readback', and the driver.

The driver is erroneously checking for that attribute with
property name of 'broken-cs'.

Check for 'no-cs-readback' in the driver as well.

Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected")
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
drivers/spi/spi-s3c64xx.c

index 3c09e94cf827f63b20f9e53d4523cbdaeba7718d..186342b74141432558bb405e865398a370b2fda4 100644 (file)
@@ -1003,7 +1003,7 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev)
                sci->num_cs = temp;
        }
 
-       sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs");
+       sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback");
 
        return sci;
 }