]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: phy: DP83822: clear MISR2 register to disable interrupts
authorClément Léger <clement.leger@bootlin.com>
Wed, 9 Mar 2022 14:22:28 +0000 (15:22 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Mar 2022 20:24:40 +0000 (12:24 -0800)
MISR1 was cleared twice but the original author intention was probably
to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
clear MISR2.

Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220309142228.761153-1-clement.leger@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/dp83822.c

index 211b5476a6f516666e004ea03382eb716a5a2103..ce17b2af3218f0c0a64a4c1535af279791407b4e 100644 (file)
@@ -274,7 +274,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
                if (err < 0)
                        return err;
 
-               err = phy_write(phydev, MII_DP83822_MISR1, 0);
+               err = phy_write(phydev, MII_DP83822_MISR2, 0);
                if (err < 0)
                        return err;