]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/loongarch/virt: Remove unused ISA Bus
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 10 Oct 2023 13:53:42 +0000 (15:53 +0200)
committerSong Gao <gaosong@loongson.cn>
Fri, 13 Oct 2023 02:03:47 +0000 (10:03 +0800)
The LoongArch 'virt' machine doesn't use its ISA I/O region.

If a ISA device were to be mapped there, there is no support
for ISA IRQ. Unlikely useful. Simply remove.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20231010135342.40219-3-philmd@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
hw/loongarch/Kconfig
hw/loongarch/virt.c
include/hw/loongarch/virt.h

index fcd5f2b4b672db62fa21cf2f74aeb3c07b0b4565..5727efed6d8442bee0217d2dcd0f2e6c1cd8c52e 100644 (file)
@@ -5,7 +5,6 @@ config LOONGARCH_VIRT
     imply VIRTIO_VGA
     imply PCI_DEVICES
     imply NVDIMM
-    select ISA_BUS
     select SERIAL
     select VIRTIO_PCI
     select PLATFORM_BUS
index c6f64e941bd7f825d43a7b6ead582ef816b450d2..c1791f80dd7d5f7e45c26be9521cc57d9d48caf4 100644 (file)
@@ -878,11 +878,6 @@ static void loongarch_init(MachineState *machine)
         machine_memory_devices_init(machine, device_mem_base, device_mem_size);
     }
 
-    /* Add isa io region */
-    memory_region_init_alias(&lams->isa_io, NULL, "isa-io",
-                             get_system_io(), 0, VIRT_ISA_IO_SIZE);
-    memory_region_add_subregion(address_space_mem, VIRT_ISA_IO_BASE,
-                                &lams->isa_io);
     /* load the BIOS image. */
     loongarch_firmware_init(lams);
 
index f1659655c64e4621cbbe15e8d0ae4bdd90da72fd..674f4655e0ee974c215a23234cff2e67fa2d03e1 100644 (file)
@@ -16,8 +16,6 @@
 
 #define LOONGARCH_MAX_CPUS      256
 
-#define VIRT_ISA_IO_BASE        0x18000000UL
-#define VIRT_ISA_IO_SIZE        0x0004000
 #define VIRT_FWCFG_BASE         0x1e020000UL
 #define VIRT_BIOS_BASE          0x1c000000UL
 #define VIRT_BIOS_SIZE          (4 * MiB)
@@ -38,7 +36,6 @@ struct LoongArchMachineState {
 
     MemoryRegion lowmem;
     MemoryRegion highmem;
-    MemoryRegion isa_io;
     MemoryRegion bios;
     bool         bios_loaded;
     /* State for other subsystems/APIs: */