]> git.proxmox.com Git - mirror_qemu.git/commitdiff
ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv
authorThomas Huth <thuth@redhat.com>
Thu, 18 Feb 2016 21:01:56 +0000 (22:01 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Thu, 25 Feb 2016 02:58:44 +0000 (13:58 +1100)
Using a CPU type that does not match the host is not possible when using
the kvm-hv kernel module - the PVR is checked in the kernel function
kvm_arch_vcpu_ioctl_set_sregs_hv() and rejected with -EINVAL if it
does not match the host.
However, when the user tries to specify a non-matching CPU type, QEMU
currently only reports "kvm_init_vcpu failed: Invalid argument", and
this is of course not very helpful for the user to solve the problem.
So this patch adds a more descriptive error message that tells the
user to specify "-cpu host" instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
[Removed melodramatic '!' :)]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
target-ppc/kvm.c

index 762d6cf3c907b211edf51ffe3d6d033ab9c84c99..d67c169ba32431788d7e3624633888376d43b63f 100644 (file)
@@ -513,6 +513,10 @@ int kvm_arch_init_vcpu(CPUState *cs)
     /* Synchronize sregs with kvm */
     ret = kvm_arch_sync_sregs(cpu);
     if (ret) {
+        if (ret == -EINVAL) {
+            error_report("Register sync failed... If you're using kvm-hv.ko,"
+                         " only \"-cpu host\" is possible");
+        }
         return ret;
     }