iwlwifi: mvm: Fix an error code in iwl_mvm_up()

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 583d18336abdfb1b355270289ff8f6a2608ba905 ]

Return -ENODEV instead of success on this error path.

Fixes: dd36a507c806 ("iwlwifi: mvm: look for the first supported channel when add/remove phy ctxt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210816183930.GA2068@kili
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit a2095c3e0309938379fd15fc74f62661e16a27ff)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index bcc032c815dcb80c210005dddc88924d7091d5cb..6d439ae7b50b136bc352ba0dc98a4cb6535142e0 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1489,8 +1489,10 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
        while (!sband && i < NUM_NL80211_BANDS)
                sband = mvm->hw->wiphy->bands[i++];
 
-       if (WARN_ON_ONCE(!sband))
+       if (WARN_ON_ONCE(!sband)) {
+               ret = -ENODEV;
                goto error;
+       }
 
        chan = &sband->channels[0];