]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drivers/isdn/i4l/isdn_tty.c: fix check for array overindexing
authorRoel Kluin <roel.kluin@gmail.com>
Wed, 10 Jun 2009 19:52:44 +0000 (12:52 -0700)
committerKarsten Keil <keil@b1-systems.de>
Thu, 11 Jun 2009 17:05:10 +0000 (19:05 +0200)
The check for overindexing of dev->mdm.info[] has an off-by-one.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Karsten Keil <keil@b1-systems.de>
drivers/isdn/i4l/isdn_tty.c

index 1a2222cbb80541bc492d78cef045f0844a08fad6..b4d4522e50718347f02b88345cc93d50608d9252 100644 (file)
@@ -1592,7 +1592,7 @@ isdn_tty_open(struct tty_struct *tty, struct file *filp)
        int retval, line;
 
        line = tty->index;
-       if (line < 0 || line > ISDN_MAX_CHANNELS)
+       if (line < 0 || line >= ISDN_MAX_CHANNELS)
                return -ENODEV;
        info = &dev->mdm.info[line];
        if (isdn_tty_paranoia_check(info, tty->name, "isdn_tty_open"))