]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
selftests/bpf: Don't check for btf fd in test_btf
authorStanislav Fomichev <sdf@google.com>
Sat, 18 Jan 2020 01:05:46 +0000 (17:05 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 20 Jan 2020 21:49:03 +0000 (22:49 +0100)
After commit 0d13bfce023a ("libbpf: Don't require root for
bpf_object__open()") we no longer load BTF during bpf_object__open(),
so let's remove the expectation from test_btf that the fd is not -1.
The test currently fails.

Before:
BTF libbpf test[1] (test_btf_haskv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1
BTF libbpf test[2] (test_btf_newkv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1
BTF libbpf test[3] (test_btf_nokv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1

After:
BTF libbpf test[1] (test_btf_haskv.o): OK
BTF libbpf test[2] (test_btf_newkv.o): OK
BTF libbpf test[3] (test_btf_nokv.o): OK

Fixes: 0d13bfce023a ("libbpf: Don't require root for bpf_object__open()")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200118010546.74279-1-sdf@google.com
tools/testing/selftests/bpf/test_btf.c

index 3d617e806054803e332d8530447c6de1ecfbbc95..93040ca83e604963044dc685634654af831274c6 100644 (file)
@@ -4148,10 +4148,6 @@ static int do_test_file(unsigned int test_num)
        if (CHECK(IS_ERR(obj), "obj: %ld", PTR_ERR(obj)))
                return PTR_ERR(obj);
 
-       err = bpf_object__btf_fd(obj);
-       if (CHECK(err == -1, "bpf_object__btf_fd: -1"))
-               goto done;
-
        prog = bpf_program__next(NULL, obj);
        if (CHECK(!prog, "Cannot find bpf_prog")) {
                err = -1;