ui: ResourceGrid: correctly remove ResourceStore listener

while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected

instead, use '.mon' on the grid, which automatically cleans up the
listeners

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/www/manager6/grid/ResourceGrid.js b/www/manager6/grid/ResourceGrid.js
index c6757e9b11361b007d5807594b2ea6eed6e23858..07048b885ba1a4f2b25c3cffc1a64308564eabf8 100644 (file)
--- a/www/manager6/grid/ResourceGrid.js
+++ b/www/manager6/grid/ResourceGrid.js
@@ -125,14 +125,11 @@ Ext.define('PVE.grid.ResourceGrid', {
                    var ws = me.up('pveStdWorkspace');
                    ws.selectById(record.data.id);
                },
-               destroy: function() {
-                   rstore.un("load", () => updateGrid());
-               },
            },
             columns: rstore.defaultColumns(),
        });
        me.callParent();
        updateGrid();
-       rstore.on("load", () => updateGrid());
+       me.mon(rstore, 'load', () => updateGrid());
     },
 });