]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/mcde: Do not use dirty GEM FB handling
authorLinus Walleij <linus.walleij@linaro.org>
Mon, 13 Mar 2023 15:51:36 +0000 (16:51 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 14 Mar 2023 16:07:49 +0000 (17:07 +0100)
This driver has no way to handle damage, the reason the
drm_gem_fb_create_with_dirty() was used was because I had the
ambition that the driver would only send out updates to DSI
command displays whenever something changed, so as to
minimize traffic.

It turns out this ambition with command mode isn't working
in practice because all the MCDE does is to create a
continuous stream of DSI commands and while it is possible to
send single frame updates with it, it's not been worthwhile.
So we are just setting up continuous updates.

Reported-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/dri-devel/0e789778-03ca-e3cb-9c94-e8b55573894c@suse.de/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230313155138.20584-24-tzimmermann@suse.de
drivers/gpu/drm/mcde/mcde_drv.c

index 4aedb050d2a599b45f365309ec091540b488e955..a592ad0d7886e5377504bf6436c47495bbb459cd 100644 (file)
@@ -94,7 +94,7 @@
 #define MCDE_PID_MAJOR_VERSION_MASK 0xFF000000
 
 static const struct drm_mode_config_funcs mcde_mode_config_funcs = {
-       .fb_create = drm_gem_fb_create_with_dirty,
+       .fb_create = drm_gem_fb_create,
        .atomic_check = drm_atomic_helper_check,
        .atomic_commit = drm_atomic_helper_commit,
 };