]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
authorLiang He <windhl@126.com>
Wed, 21 Sep 2022 13:32:45 +0000 (21:32 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Sep 2022 14:23:58 +0000 (07:23 -0700)
In prestera_port_sfp_bind(), there are two refcounting bugs:
(1) we should call of_node_get() before of_find_node_by_name() as
it will automaitcally decrease the refcount of 'from' argument;
(2) we should call of_node_put() for the break of the iteration
for_each_child_of_node() as it will automatically increase and
decrease the 'child'.

Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Link: https://lore.kernel.org/r/20220921133245.4111672-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/prestera/prestera_main.c

index ede3e53b97901a16c6c347036920058a27abda6b..a895862b48212fa23f8216967e40a7fb38628747 100644 (file)
@@ -368,6 +368,7 @@ static int prestera_port_sfp_bind(struct prestera_port *port)
        if (!sw->np)
                return 0;
 
+       of_node_get(sw->np);
        ports = of_find_node_by_name(sw->np, "ports");
 
        for_each_child_of_node(ports, node) {
@@ -417,6 +418,7 @@ static int prestera_port_sfp_bind(struct prestera_port *port)
        }
 
 out:
+       of_node_put(node);
        of_node_put(ports);
        return err;
 }