In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
info.irq = dev->irq;
dev->slave = i2c_new_client_device(&dev->adapter, &info);
- if (!dev->slave)
- return -ENODEV;
+ if (IS_ERR(dev->slave))
+ return PTR_ERR(dev->slave);
return 0;
}