]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: wfx: remove useless extra jiffy
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Tue, 25 Aug 2020 08:58:27 +0000 (10:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Aug 2020 10:19:51 +0000 (12:19 +0200)
The initial developer has feared msecs_to_jiffies() could round down the
result. However, the documentation of msecs_to_jiffies() says that the
result is rounded upward. So the increment of the result of
msecs_to_jiffies() is not necessary.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200825085828.399505-11-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/bh.c

index 53ae0b5abcdd82917033aa7a6eae02777ff4ad8c..07304a80c29bb911e86492928ab53f65d8414a6f 100644 (file)
@@ -33,7 +33,7 @@ static void device_wakeup(struct wfx_dev *wdev)
                // wait_for_completion_done_timeout()). So we have to emulate
                // it.
                if (wait_for_completion_timeout(&wdev->hif.ctrl_ready,
-                                               msecs_to_jiffies(2) + 1))
+                                               msecs_to_jiffies(2)))
                        complete(&wdev->hif.ctrl_ready);
                else
                        dev_err(wdev->dev, "timeout while wake up chip\n");