staging: unisys: visorhba: switch success handling to error handling

Addresses code audit feeback to switch from success handling to error
handling in visorhba_main.c/process_disk_notify().

Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index 7a2c48943b84300c05bfaf22d22026ac28942d91..6a4570d1064259d5d733fc92dc599a90c49c9eb6 100644 (file)
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -950,14 +950,15 @@ static void process_disk_notify(struct Scsi_Host *shost,
        struct diskaddremove *dar;
 
        dar = kzalloc(sizeof(*dar), GFP_ATOMIC);
-       if (dar) {
-               dar->add = cmdrsp->disknotify.add;
-               dar->shost = shost;
-               dar->channel = cmdrsp->disknotify.channel;
-               dar->id = cmdrsp->disknotify.id;
-               dar->lun = cmdrsp->disknotify.lun;
-               queue_disk_add_remove(dar);
-       }
+       if (!dar)
+               return;
+
+       dar->add = cmdrsp->disknotify.add;
+       dar->shost = shost;
+       dar->channel = cmdrsp->disknotify.channel;
+       dar->id = cmdrsp->disknotify.id;
+       dar->lun = cmdrsp->disknotify.lun;
+       queue_disk_add_remove(dar);
 }
 
 /**