gve: Use link status register to report link status

This makes the driver better aware of the connectivity status of the
device. Based on the device's status register, the driver can call
netif_carrier_{on,off}.

Reviewed-by: Yangchun Fu <yangchun@google.com>
Signed-off-by: Patricio Noyola <patricion@google.com>
Signed-off-by: David Awogbemila <awogbemila@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 28e5cc52410e7208f665b72d28d84613d0274e73..48a433154ce079c8c45cd8aae53eed7e0d3e5e04 100644 (file)
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -774,7 +774,7 @@ static int gve_open(struct net_device *dev)
                                msecs_to_jiffies(priv->stats_report_timer_period)));
 
        gve_turnup(priv);
-       netif_carrier_on(dev);
+       queue_work(priv->gve_wq, &priv->service_task);
        priv->interface_up_cnt++;
        return 0;
 
@@ -1032,16 +1032,34 @@ void gve_handle_report_stats(struct gve_priv *priv)
        }
 }
 
+static void gve_handle_link_status(struct gve_priv *priv, bool link_status)
+{
+       if (!gve_get_napi_enabled(priv))
+               return;
+
+       if (link_status == netif_carrier_ok(priv->dev))
+               return;
+
+       if (link_status) {
+               netdev_info(priv->dev, "Device link is up.\n");
+               netif_carrier_on(priv->dev);
+       } else {
+               netdev_info(priv->dev, "Device link is down.\n");
+               netif_carrier_off(priv->dev);
+       }
+}
+
 /* Handle NIC status register changes, reset requests and report stats */
 static void gve_service_task(struct work_struct *work)
 {
        struct gve_priv *priv = container_of(work, struct gve_priv,
                                             service_task);
+       u32 status = ioread32be(&priv->reg_bar0->device_status);
 
-       gve_handle_status(priv,
-                         ioread32be(&priv->reg_bar0->device_status));
+       gve_handle_status(priv, status);
 
        gve_handle_reset(priv);
+       gve_handle_link_status(priv, GVE_DEVICE_STATUS_LINK_STATUS_MASK & status);
 }
 
 static int gve_init_priv(struct gve_priv *priv, bool skip_describe_device)