]> git.proxmox.com Git - pve-manager.git/commitdiff
Do not disable a invalid previous tab, as this make the tab fields valid
authorEmmanuel Kasper <e.kasper@proxmox.com>
Mon, 11 Apr 2016 12:35:59 +0000 (14:35 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Tue, 12 Apr 2016 15:11:02 +0000 (17:11 +0200)
disable_at() iterates over all the fields of the previously selected
tab and disables them
however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields
is needed, since the tab already hidden
and after testing, it seems safe to remove this call

this fix a problem when going back and forth in the wizard would
make some fields uneditable for the wrong reason

www/manager6/window/Wizard.js

index 82dd04f1649ef3aa2f2378340a2806fef63e69d7..d2d5aaee8a6f49b4dcd7beb8ce5d7ca1ece9405c 100644 (file)
@@ -156,10 +156,6 @@ Ext.define('PVE.window.Wizard', {
            me.down('#submit').setDisabled(!valid);    
            me.down('#back').setDisabled(tp.items.indexOf(newcard) == 0);
 
-           if (oldcard && !check_card(oldcard)) {
-               disable_at(oldcard);
-           }
-
            var next = tp.items.indexOf(newcard) + 1;
            var ntab = tp.items.getAt(next);
            if (valid && ntab && !newcard.onSubmit) {