]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
skbuff: Add likely to skb pointer in build_skb()
authorGal Pressman <gal@nvidia.com>
Wed, 8 Mar 2023 13:17:20 +0000 (15:17 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 Mar 2023 00:49:21 +0000 (16:49 -0800)
Similarly to napi_build_skb(), it is likely the skb allocation in
build_skb() succeeded. frag_size != 0 is also likely, as stated in
__build_skb_around().

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c

index de465368fc2c2d351717165bedc53d2097e6ff26..050a875d09c5535e0cb2e52c9c65f3febd0385d6 100644 (file)
@@ -420,7 +420,7 @@ struct sk_buff *build_skb(void *data, unsigned int frag_size)
 {
        struct sk_buff *skb = __build_skb(data, frag_size);
 
-       if (skb && frag_size) {
+       if (likely(skb && frag_size)) {
                skb->head_frag = 1;
                skb_propagate_pfmemalloc(virt_to_head_page(data), skb);
        }