]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
RDS: drop double zeroing
authorJulia Lawall <Julia.Lawall@inria.fr>
Sun, 20 Sep 2020 11:26:19 +0000 (13:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Sep 2020 02:09:11 +0000 (19:09 -0700)
sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
  (n,sizeof(*x),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/rdma.c

index ccdd304eae0a0a47ece2df8130c25500592d9124..1d0afb1dd77b5cfc78b46a88451b15c4f1a44069 100644 (file)
@@ -269,7 +269,7 @@ static int __rds_rdma_map(struct rds_sock *rs, struct rds_get_mr_args *args,
                goto out;
        } else {
                nents = ret;
-               sg = kcalloc(nents, sizeof(*sg), GFP_KERNEL);
+               sg = kmalloc_array(nents, sizeof(*sg), GFP_KERNEL);
                if (!sg) {
                        ret = -ENOMEM;
                        goto out;