staging: unisys: visorbus: Remove unneeded checks for valid variable addr

The 'retry' variable created in handle_command() is statically allocated,
and its address is never set to NULL. Therefore conditionals to verify
the validity of the retry variable's address are unnecessary.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 275653ac6a68f48bc7bf945c2fd67eee6be6cda1..b6f1ccf03d606c1a9cebe6eefb792e46d5f8f5ea 100644 (file)
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1852,8 +1852,7 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
        int allocbytes = sizeof(struct parser_context) + bytes;
        struct parser_context *ctx;
 
-       if (retry)
-               *retry = false;
+       *retry = false;
 
        /*
         * alloc an 0 extra byte to ensure payload is
@@ -1862,14 +1861,12 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
        allocbytes++;
        if ((controlvm_payload_bytes_buffered + bytes)
            > MAX_CONTROLVM_PAYLOAD_BYTES) {
-               if (retry)
-                       *retry = true;
+               *retry = true;
                return NULL;
        }
        ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY);
        if (!ctx) {
-               if (retry)
-                       *retry = true;
+               *retry = true;
                return NULL;
        }