]> git.proxmox.com Git - libgit2.git/commitdiff
config: show we write a spurious duplicated section header
authorCarlos Martín Nieto <cmn@dwim.me>
Fri, 4 Mar 2016 13:51:16 +0000 (14:51 +0100)
committerEdward Thomson <ethomson@github.com>
Mon, 28 Mar 2016 14:47:14 +0000 (10:47 -0400)
We should notice that we are in the correct section to add. This is a
cosmetic bug, since replacing any of these settings does work.

tests/config/write.c

index e634aa326cd8669b1fdc6ebed456965cd5223c04..ac0272eac88a9cc805f7324d7481be5af42397d1 100644 (file)
@@ -695,3 +695,27 @@ void test_config_write__locking(void)
 
        git_config_free(cfg);
 }
+
+void test_config_write__repeated(void)
+{
+       const char *filename = "config-repeated";
+       git_config *cfg;
+       git_buf result;
+       const char *expected = "[sample \"prefix\"]\n\
+\tsetting1 = someValue1\n\
+\tsetting2 = someValue2\n\
+\tsetting3 = someValue3\n\
+\tsetting4 = someValue4\n\
+";
+       cl_git_pass(git_config_open_ondisk(&cfg, filename));
+       cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting1", "someValue1"));
+       cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting2", "someValue2"));
+       cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting3", "someValue3"));
+       cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting4", "someValue4"));
+
+       cl_git_pass(git_config_open_ondisk(&cfg, filename));
+
+       cl_git_pass(git_futils_readbuffer(&result, filename));
+       cl_assert_equal_s(expected, result.ptr);
+       git_buf_free(&result);
+}