]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
PM: Reset transition_started at dpm_resume_noirq
authorXiaotian Feng <dfeng@redhat.com>
Thu, 20 Aug 2009 18:28:33 +0000 (20:28 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Mon, 14 Sep 2009 18:27:00 +0000 (20:27 +0200)
transition_started should be set once the preparation of devices for
a PM has started, reset before starting to resume devices. When
resuming devices, kernel calls dpm_resume_noirq then
dpm_resume_end(dpm_resume).  Thus we should reset transition_started
at dpm_resume_noirq.

This patch fixes ACPI warning when resuming from suspend/hibernate:

ACPI: \_SB_.PCI0.IDE1.PRI1.MAS1 - docking
------------[ cut here ]------------
WARNING: at drivers/base/power/main.c:87 device_pm_add+0x8b/0xcc()
Hardware name: OptiPlex 760
Device: acpi
Parentless device registered during a PM transaction

[rjw: Fixed up the changelog.]

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
drivers/base/power/main.c

index b0899118569b7270720859fd374c25b7c0b25001..e0dc4071e088209aab36d51a69bf658062503fd7 100644 (file)
@@ -365,6 +365,7 @@ void dpm_resume_noirq(pm_message_t state)
        struct device *dev;
 
        mutex_lock(&dpm_list_mtx);
+       transition_started = false;
        list_for_each_entry(dev, &dpm_list, power.entry)
                if (dev->power.status > DPM_OFF) {
                        int error;
@@ -443,7 +444,6 @@ static void dpm_resume(pm_message_t state)
 
        INIT_LIST_HEAD(&list);
        mutex_lock(&dpm_list_mtx);
-       transition_started = false;
        while (!list_empty(&dpm_list)) {
                struct device *dev = to_device(dpm_list.next);