]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: atlantic: Remove unnecessary conversion to bool
authorKaixu Xia <kaixuxia@tencent.com>
Sun, 8 Nov 2020 01:11:59 +0000 (09:11 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Nov 2020 23:24:49 +0000 (15:24 -0800)
The '!=' expression itself is bool, no need to convert it to bool.
Fix the following coccicheck warning:

./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1604797919-10157-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/aquantia/atlantic/aq_nic.c

index bf5e0e9bd0e2b0c1bbb267537ea035632053862a..6c049864dac0812cae377adadc366c3db5ffda63 100644 (file)
@@ -1474,7 +1474,7 @@ int aq_nic_setup_tc_mqprio(struct aq_nic_s *self, u32 tcs, u8 *prio_tc_map)
                for (i = 0; i < sizeof(cfg->prio_tc_map); i++)
                        cfg->prio_tc_map[i] = cfg->tcs * i / 8;
 
-       cfg->is_qos = (tcs != 0 ? true : false);
+       cfg->is_qos = !!tcs;
        cfg->is_ptp = (cfg->tcs <= AQ_HW_PTP_TC);
        if (!cfg->is_ptp)
                netdev_warn(self->ndev, "%s\n",