]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628
authorGuenter Roeck <linux@roeck-us.net>
Wed, 8 Feb 2017 22:05:56 +0000 (14:05 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 20 Jun 2017 08:45:50 +0000 (10:45 +0200)
BugLink: http://bugs.launchpad.net/bugs/1691369
commit d66777caa57ffade6061782f3a4d4056f0b0c1ac upstream.

pwm4 is enabled if bit 2 of GPIO control register 4 is disabled,
not when it is enabled. Since the check is for the skip condition,
it is reversed. This applies to both IT8620 and IT8628.

Fixes: 36c4d98a7883d ("hwmon: (it87) Add support for all pwm channels ...")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/hwmon/it87.c

index b99c1df48156f02458b75cba8c76e4e523000fef..81853ee85f6a25824277da125d6c020d405e7a47 100644 (file)
@@ -2600,7 +2600,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
 
                /* Check for pwm4 */
                reg = superio_inb(sioaddr, IT87_SIO_GPIO4_REG);
-               if (!(reg & BIT(2)))
+               if (reg & BIT(2))
                        sio_data->skip_pwm |= BIT(3);
 
                /* Check for pwm2, fan2 */