]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
video: delete unneeded call to platform_get_drvdata
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 17 May 2014 06:32:49 +0000 (08:32 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 19 May 2014 13:03:57 +0000 (16:03 +0300)
Platform_get_drvdata is an accessor function, and has no purpose if its
result is not used.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
type T;
@@
- T x = platform_get_drvdata(...);
... when != x
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/bf54x-lq043fb.c

index e2c42ad8515add8c59d3c29d3276abd40a12f1f0..adbef542c998d5f09a1c1c089161f3990d0c3dcf 100644 (file)
@@ -717,8 +717,6 @@ static int bfin_bf54x_remove(struct platform_device *pdev)
 #ifdef CONFIG_PM
 static int bfin_bf54x_suspend(struct platform_device *pdev, pm_message_t state)
 {
-       struct fb_info *fbinfo = platform_get_drvdata(pdev);
-
        bfin_write_EPPI0_CONTROL(bfin_read_EPPI0_CONTROL() & ~EPPI_EN);
        disable_dma(CH_EPPI0);
        bfin_write_EPPI0_STATUS(0xFFFF);