]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
usb: mtu3: fix memory corruption in mtu3_debugfs_regset()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 Dec 2020 08:41:13 +0000 (11:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Dec 2020 14:26:18 +0000 (15:26 +0100)
This code is using the wrong sizeof() so it does not allocate enough
memory.  It allocates 32 bytes but 72 are required.  That will lead to
memory corruption.

Fixes: ae07809255d3 ("usb: mtu3: add debugfs interface files")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X8ikqc4Mo2/0G72j@mwanda
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/mtu3/mtu3_debugfs.c

index fdeade6254aeccad2bb13da9ac7dbce4edaa23b6..7537bfd651af6d0a1d2d6686ec0c7582f8b75517 100644 (file)
@@ -127,7 +127,7 @@ static void mtu3_debugfs_regset(struct mtu3 *mtu, void __iomem *base,
        struct debugfs_regset32 *regset;
        struct mtu3_regset *mregs;
 
-       mregs = devm_kzalloc(mtu->dev, sizeof(*regset), GFP_KERNEL);
+       mregs = devm_kzalloc(mtu->dev, sizeof(*mregs), GFP_KERNEL);
        if (!mregs)
                return;