]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
powerpc/xive: Do not mark xive_request_ipi() as __init
authorNathan Chancellor <nathan@kernel.org>
Mon, 16 Aug 2021 18:57:11 +0000 (11:57 -0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 18 Aug 2021 13:52:13 +0000 (23:52 +1000)
Compiling ppc64le_defconfig with clang-14 shows a modpost warning:

WARNING: modpost: vmlinux.o(.text+0xa74e0): Section mismatch in
reference from the function xive_setup_cpu_ipi() to the function
.init.text:xive_request_ipi()
The function xive_setup_cpu_ipi() references
the function __init xive_request_ipi().
This is often because xive_setup_cpu_ipi lacks a __init
annotation or the annotation of xive_request_ipi is wrong.

xive_request_ipi() is called from xive_setup_cpu_ipi(), which is not
__init, so xive_request_ipi() should not be marked __init. Remove the
attribute so there is no more warning.

Fixes: cbc06f051c52 ("powerpc/xive: Do not skip CPU-less nodes when creating the IPIs")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210816185711.21563-1-nathan@kernel.org
arch/powerpc/sysdev/xive/common.c

index 943fd30095af4e61eae4a6dc2fa28029bd14b4c5..8183ca343675a4c3c90ca806fddd6d3fc5d2c6dd 100644 (file)
@@ -1170,7 +1170,7 @@ out:
        return ret;
 }
 
-static int __init xive_request_ipi(unsigned int cpu)
+static int xive_request_ipi(unsigned int cpu)
 {
        struct xive_ipi_desc *xid = &xive_ipis[early_cpu_to_node(cpu)];
        int ret;