]> git.proxmox.com Git - pve-storage.git/commitdiff
rbd, zfs, sheepdog: bugfix : fix alloc_image if name is specified
authorAlexandre Derumier <aderumier@odiso.com>
Thu, 20 Nov 2014 15:01:44 +0000 (16:01 +0100)
committerDietmar Maurer <dietmar@proxmox.com>
Fri, 21 Nov 2014 07:03:08 +0000 (08:03 +0100)
Currently vmstate snapshot with rbd have wrong name,
because rbd alloc_image don't care if $name is provided

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
PVE/Storage/RBDPlugin.pm
PVE/Storage/SheepdogPlugin.pm
PVE/Storage/ZFSPlugin.pm

index 1026d8162fb6404b6846f9aefab80ce613b65476..2c1f6155242ebaa4220ea5458dc42d299ef6d324 100644 (file)
@@ -382,7 +382,7 @@ sub alloc_image {
     die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
        if  $name && $name !~ m/^vm-$vmid-/;
 
-    $name = &$find_free_diskname($storeid, $scfg, $vmid);
+    $name = &$find_free_diskname($storeid, $scfg, $vmid) if !$name;
 
     my $cmd = &$rbd_cmd($scfg, $storeid, 'create', '--image-format' , 2, '--size', int(($size+1023)/1024), $name);
     run_rbd_command($cmd, errmsg => "rbd create $name' error");
index 8e1ca0c11dbe84d000e5beef08dd3c946d451b1a..3e2c12657151e8dad2d3c97f53800acb7e38a6cc 100644 (file)
@@ -242,7 +242,7 @@ sub alloc_image {
     die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
        if  $name && $name !~ m/^vm-$vmid-/;
 
-    $name = &$find_free_diskname($storeid, $scfg, $vmid);
+    $name = &$find_free_diskname($storeid, $scfg, $vmid) if !$name;
 
     my $cmd = &$collie_cmd($scfg, 'vdi', 'create', $name , "${size}k");
 
index b47f8148ade58960fb16f8d851b4282b8929eb63..44a8ccb68d285e80aece471831f5ca74995254be 100644 (file)
@@ -478,7 +478,7 @@ sub alloc_image {
     die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
     if $name && $name !~ m/^vm-$vmid-/;
 
-    $name = &$find_free_diskname($storeid, $scfg, $vmid);
+    $name = &$find_free_diskname($storeid, $scfg, $vmid) if !$name;
 
     zfs_create_zvol($scfg, $name, $size);
     my $guid = zfs_create_lu($scfg, $name);