]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
staging: rtl8723au: fix static checker warning
authorGeliang Tang <geliangtang@163.com>
Tue, 1 Mar 2016 15:22:23 +0000 (23:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
Fix the following static checker warning:

 drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a()
 error: potential NULL dereference 'psta'.

Fixes: e280d71("staging: rtl8723au: use list_for_each_entry*()")
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/core/rtw_sta_mgt.c

index 22d857b6e8d0dcd12b11fe67bb832df232626eae..5f85ee065779eb989fddfb7b22c9c740c34402db 100644 (file)
@@ -346,7 +346,7 @@ void rtw_free_all_stainfo23a(struct rtw_adapter *padapter)
 struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr)
 {
        struct list_head *phead;
-       struct sta_info *psta = NULL;
+       struct sta_info *pos, *psta = NULL;
        u32 index;
        const u8 *addr;
 
@@ -362,7 +362,9 @@ struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr)
 
        spin_lock_bh(&pstapriv->sta_hash_lock);
        phead = &pstapriv->sta_hash[index];
-       list_for_each_entry(psta, phead, hash_list) {
+       list_for_each_entry(pos, phead, hash_list) {
+               psta = pos;
+
                /*  if found the matched address */
                if (ether_addr_equal(psta->hwaddr, addr))
                        break;