]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
vlan: Remove unnecessary comparison of unsigned against 0
authorTobias Klauser <tklauser@distanz.ch>
Tue, 18 Oct 2016 06:44:17 +0000 (08:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Oct 2016 14:25:34 +0000 (10:25 -0400)
args.u.name_type is of type unsigned int and is always >= 0.

This fixes the following GCC warning:

  net/8021q/vlan.c: In function ‘vlan_ioctl_handler’:
  net/8021q/vlan.c:574:14: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan.c

index 8de138d3306bdbe6f3164db323637ded5bf5b5b3..f8903c1e10109a734a99172f696c233ad37867cf 100644 (file)
@@ -571,8 +571,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg)
                err = -EPERM;
                if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
                        break;
-               if ((args.u.name_type >= 0) &&
-                   (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) {
+               if (args.u.name_type < VLAN_NAME_TYPE_HIGHEST) {
                        struct vlan_net *vn;
 
                        vn = net_generic(net, vlan_net_id);