]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
md: allow a resync that is waiting for other resync to complete, to be aborted.
authorNeilBrown <neilb@suse.de>
Wed, 30 Dec 2009 04:25:23 +0000 (15:25 +1100)
committerNeilBrown <neilb@suse.de>
Wed, 30 Dec 2009 04:25:23 +0000 (15:25 +1100)
If two arrays share a device, then they will not both resync at the
same time.  One will wait for the other to complete.
While waiting, the MD_RECOVERY_INTR flag is not checked so a device
failure, which would make the resync pointless, does not cause the
resync to abort, so the failed device cannot be removed (as it cannot
be remove while a resync is happening).

So add a test for MD_RECOVERY_INTR.

Reported-by: Brett Russ <bruss@netezza.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/md.c

index c4bdf0601757f21f4b825993ff30a98205f74cf5..dd3dfe42d5a9d081c590018f1ac6325cfecdaf12 100644 (file)
@@ -6473,10 +6473,11 @@ void md_do_sync(mddev_t *mddev)
                mddev->curr_resync = 2;
 
        try_again:
-               if (kthread_should_stop()) {
+               if (kthread_should_stop())
                        set_bit(MD_RECOVERY_INTR, &mddev->recovery);
+
+               if (test_bit(MD_RECOVERY_INTR, &mddev->recovery))
                        goto skip;
-               }
                for_each_mddev(mddev2, tmp) {
                        if (mddev2 == mddev)
                                continue;