]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
serial: vt8500: ioremap'd resource is never freed
authorTony Prisk <linux@prisktech.co.nz>
Wed, 16 Jan 2013 19:05:41 +0000 (08:05 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jan 2013 01:24:15 +0000 (17:24 -0800)
Memory mapped via ioremap call is never released. Rather than add an
iounmap call, change allocation function to devm_request_and_ioremap.

Also, change the error on failure for this call to -EADDRNOTAVAIL rather than
-ENOMEM.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/vt8500_serial.c

index e50deb771616407d6a7fd035bb967a18f9609948..ff391db0a22041c543e7dd261a066f16cf008fff 100644 (file)
@@ -606,9 +606,9 @@ static int vt8500_serial_probe(struct platform_device *pdev)
        snprintf(vt8500_port->name, sizeof(vt8500_port->name),
                 "VT8500 UART%d", pdev->id);
 
-       vt8500_port->uart.membase = ioremap(mmres->start, resource_size(mmres));
+       vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres);
        if (!vt8500_port->uart.membase) {
-               ret = -ENOMEM;
+               ret = -EADDRNOTAVAIL;
                goto err;
        }