]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
rsi: Assign beacon rate settings to the correct rate_info descriptor field
authorMarek Vasut <marex@denx.de>
Fri, 7 May 2021 21:31:05 +0000 (23:31 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:29:51 +0000 (09:29 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938340
commit b1c3a24897bd528f2f4fda9fea7da08a84ae25b6 upstream.

The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info
field. The rest of the driver does it correctly, except this one place,
so fix it. This is also aligned with the RSI downstream vendor driver.
Without this patch, an AP operating at 5 GHz does not transmit any
beacons at all, this patch fixes that.

Fixes: d26a9559403c ("rsi: add beacon changes for AP mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Cc: Angus Ainslie <angus@akkea.ca>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Karun Eagalapati <karun256@gmail.com>
Cc: Martin Kepplinger <martink@posteo.de>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210507213105.140138-1-marex@denx.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/wireless/rsi/rsi_91x_hal.c

index ce9892152f4d4089075645bf47a4dfbc7c3d32e9..ab837921d9a474100462c5eacbf26bf22a4acaf0 100644 (file)
@@ -470,9 +470,9 @@ int rsi_prepare_beacon(struct rsi_common *common, struct sk_buff *skb)
        }
 
        if (common->band == NL80211_BAND_2GHZ)
-               bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_1);
+               bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_1);
        else
-               bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_6);
+               bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_6);
 
        if (mac_bcn->data[tim_offset + 2] == 0)
                bcn_frm->frame_info |= cpu_to_le16(RSI_DATA_DESC_DTIM_BEACON);