]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
USB: rndis_host: debug info clobbered before it is logged
authorGeorge Nassar <george.nassar@gmail.com>
Wed, 14 Oct 2009 23:27:41 +0000 (18:27 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 30 Oct 2009 21:57:33 +0000 (14:57 -0700)
The MTU throttle-down if a RNDIS device doesn't support a particular
packet size is being incorrectly logged.  The attempted packet size is
being clobbered before it gets logged.

First patch; please inform if I'm doing this incorrectly.  Diff'd
against latest official source as per the FAQ; forward port to current
git version is straightforward.

Signed-off-by: George Nassar <george.nassar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/usb/rndis_host.c

index 0caa8008c51c0483b69e0bfa553555aa7fe05864..f56dec6119c3fcadb97740dd1d2d0cad33fef487 100644 (file)
@@ -362,12 +362,12 @@ generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags)
                        retval = -EINVAL;
                        goto halt_fail_and_release;
                }
-               dev->hard_mtu = tmp;
-               net->mtu = dev->hard_mtu - net->hard_header_len;
                dev_warn(&intf->dev,
                         "dev can't take %u byte packets (max %u), "
                         "adjusting MTU to %u\n",
-                        dev->hard_mtu, tmp, net->mtu);
+                        dev->hard_mtu, tmp, tmp - net->hard_header_len);
+               dev->hard_mtu = tmp;
+               net->mtu = dev->hard_mtu - net->hard_header_len;
        }
 
        /* REVISIT:  peripheral "alignment" request is ignored ... */