]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
net: hns3: Add missing break in misc_irq_handle
authorYunsheng Lin <linyunsheng@huawei.com>
Fri, 1 Jun 2018 16:52:08 +0000 (17:52 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 6 Jun 2018 18:41:30 +0000 (14:41 -0400)
BugLink: https://bugs.launchpad.net/bugs/1768670
There is a break missing in the switch/case handling in
hclge_misc_irq_handle, which causes the log to output
uncorrectly.

This patch adds the missing break, and change the dev_dbg
to dev_warn in order to better catch the error.

Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit f0ad97ac12f0e91cf3846025256ca97845bcfccd linux-next)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 58fef5e56831510c6eea4b1992b20d574d93f8a4..19e56896887d1fc0f567a58d5aff712269d41b6a 100644 (file)
@@ -2580,10 +2580,10 @@ static irqreturn_t hclge_misc_irq_handle(int irq, void *data)
                 * mbx messages reported by this interrupt.
                 */
                hclge_mbx_task_schedule(hdev);
-
+               break;
        default:
-               dev_dbg(&hdev->pdev->dev,
-                       "received unknown or unhandled event of vector0\n");
+               dev_warn(&hdev->pdev->dev,
+                        "received unknown or unhandled event of vector0\n");
                break;
        }