]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
ovs/geneve: fix rtnl notifications on iface deletion
authorNicolas Dichtel <nicolas.dichtel@6wind.com>
Mon, 13 Jun 2016 08:31:07 +0000 (10:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Jun 2016 05:21:45 +0000 (22:21 -0700)
The function geneve_dev_create_fb() (only used by ovs) never calls
rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
never set to RTNL_LINK_INITIALIZED.
During the deletion phase, the function rollback_registered_many() sends
a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.

Fixes: e305ac6cf5a1 ("geneve: Add support to collect tunnel metadata.")
CC: Pravin B Shelar <pshelar@nicira.com>
CC: Jesse Gross <jesse@nicira.com>
CC: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/geneve.c

index 086c2dae4c3d952f4f30ef40cc9b28575895e86b..305a04e45a1310fcb9001d04aeb16a826711d23d 100644 (file)
@@ -1532,6 +1532,10 @@ struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
        if (err)
                goto err;
 
+       err = rtnl_configure_link(dev, NULL);
+       if (err < 0)
+               goto err;
+
        return dev;
 
  err: