]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ibmveth: Identify ingress large send packets.
authorDavid Wilder <dwilder@us.ibm.com>
Tue, 13 Oct 2020 23:20:14 +0000 (16:20 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 15 Oct 2020 03:16:31 +0000 (20:16 -0700)
Ingress large send packets are identified by either:
The IBMVETH_RXQ_LRG_PKT flag in the receive buffer
or with a -1 placed in the ip header checksum.
The method used depends on firmware version. Frame
geometry and sufficient header validation is performed by the
hypervisor eliminating the need for further header checks here.

Fixes: 7b5967389f5a ("ibmveth: set correct gso_size and gso_type")
Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Reviewed-by: Cristobal Forno <cris.forno@ibm.com>
Reviewed-by: Pradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmveth.c

index 3935a7e22ce5dd577f9daa3d0c7c1b3b94bd416b..7ef3369953b6a540fa15c7ad9cb192d50f570a3e 100644 (file)
@@ -1349,6 +1349,7 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
                        int offset = ibmveth_rxq_frame_offset(adapter);
                        int csum_good = ibmveth_rxq_csum_good(adapter);
                        int lrg_pkt = ibmveth_rxq_large_packet(adapter);
+                       __sum16 iph_check = 0;
 
                        skb = ibmveth_rxq_get_buffer(adapter);
 
@@ -1385,7 +1386,17 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
                        skb_put(skb, length);
                        skb->protocol = eth_type_trans(skb, netdev);
 
-                       if (length > netdev->mtu + ETH_HLEN) {
+                       /* PHYP without PLSO support places a -1 in the ip
+                        * checksum for large send frames.
+                        */
+                       if (skb->protocol == cpu_to_be16(ETH_P_IP)) {
+                               struct iphdr *iph = (struct iphdr *)skb->data;
+
+                               iph_check = iph->check;
+                       }
+
+                       if ((length > netdev->mtu + ETH_HLEN) ||
+                           lrg_pkt || iph_check == 0xffff) {
                                ibmveth_rx_mss_helper(skb, mss, lrg_pkt);
                                adapter->rx_large_packets++;
                        }