ui: pending revert: detect parent pending grid automatically

but cache it to avoid frequent, potential costly, up() calls

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/manager6/button/Revert.js b/www/manager6/button/Revert.js
index 1661b64b90a87e502150957266a0731b7747ec03..88293641b82dc9297039d6d31c1a470d36876bcf 100644 (file)
--- a/www/manager6/button/Revert.js
+++ b/www/manager6/button/Revert.js
@@ -10,6 +10,10 @@ Ext.define('PVE.button.PendingRevert', {
     },
 
     handler: function() {
+       if (!this.pendingGrid) {
+           this.pendingGrid = this.up('proxmoxPendingObjectGrid');
+           if (!this.pendingGrid) throw "revert button requires a pendingGrid";
+       }
        let view = this.pendingGrid;
 
        let rec = view.getSelectionModel().getSelection()[0];
@@ -30,9 +34,4 @@ Ext.define('PVE.button.PendingRevert', {
            failure: (response) => Ext.Msg.alert('Error', response.htmlStatus),
        });
     },
-
-    initComponent: function() {
-       if (!this.pendingGrid) throw "revert button requires a pendingGrid";
-       this.callParent(arguments);
-    },
 });

diff --git a/www/manager6/lxc/DNS.js b/www/manager6/lxc/DNS.js
index bf110f0913d66bd85862731ca23fe4e2d1f764be..655c6817559f2357b25302d399b5d78d2deb06e0 100644 (file)
--- a/www/manager6/lxc/DNS.js
+++ b/www/manager6/lxc/DNS.js
@@ -213,9 +213,7 @@ Ext.define('PVE.lxc.DNS', {
            handler: run_editor
        });
 
-       var revert_btn = new PVE.button.PendingRevert({
-           pendingGrid: me,
-       });
+       var revert_btn = new PVE.button.PendingRevert();
 
        var set_button_status = function() {
            var sm = me.getSelectionModel();

diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 409f8b709d9d1bf168e5f6d5581ad2dfc4a53a2c..519c4e137550fd8cc59733c9cc3d48626b1f300e 100644 (file)
--- a/www/manager6/lxc/Options.js
+++ b/www/manager6/lxc/Options.js
@@ -161,9 +161,7 @@ Ext.define('PVE.lxc.Options', {
            handler: function() { me.run_editor(); }
        });
 
-       var revert_btn = new PVE.button.PendingRevert({
-           pendingGrid: me,
-       });
+       var revert_btn = new PVE.button.PendingRevert();
 
        var set_button_status = function() {
            var sm = me.getSelectionModel();

diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
index f70f9e029582f718951c60f6c47e1e6d55779e3e..f6358122d59596f2a06648455d08cf5c36fc62e1 100644 (file)
--- a/www/manager6/lxc/Resources.js
+++ b/www/manager6/lxc/Resources.js
@@ -215,9 +215,7 @@ Ext.define('PVE.lxc.RessourceView', {
            handler: run_move
        });
 
-       var revert_btn = new PVE.button.PendingRevert({
-           pendingGrid: me,
-       });
+       var revert_btn = new PVE.button.PendingRevert();
 
        var set_button_status = function() {
            var rec = me.selModel.getSelection()[0];

diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index 6afb55ca5b9fa775953bc259b4965ddbe45a8324..2de32611d53064057dfff1d802b2ee17f442ff54 100644 (file)
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -501,7 +501,6 @@ Ext.define('PVE.qemu.HardwareView', {
        });
 
        var revert_btn = new PVE.button.PendingRevert({
-           pendingGrid: me,
            apiurl: '/api2/extjs/' + baseurl,
        });
 

diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index ef66fcfda663afdf0306d99ae1e021b93fd52a3f..e6f279c8affe1a097920cf312f6a5a57a760e8d1 100644 (file)
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -309,9 +309,7 @@ Ext.define('PVE.qemu.Options', {
            handler: function() { me.run_editor(); }
        });
 
-       var revert_btn = new PVE.button.PendingRevert({
-           pendingGrid: me,
-       });
+       var revert_btn = new PVE.button.PendingRevert();
 
        var set_button_status = function() {
            var sm = me.getSelectionModel();