]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
dmaengine: stm32-dmamux: Fix a NULL vs IS_ERR() check in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 3 Oct 2017 10:54:50 +0000 (13:54 +0300)
committerVinod Koul <vinod.koul@intel.com>
Sun, 8 Oct 2017 10:47:39 +0000 (16:17 +0530)
devm_ioremap_resource() doesn't return NULL, it returns error pointers.

Fixes: df7e762db5f6 ("dmaengine: Add STM32 DMAMUX driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/stm32-dmamux.c

index 22812e7a953b93309f8be7ca69cc3d5cd47879e8..d5db0f6e1ff886f11404ad4712cc98581167edcb 100644 (file)
@@ -257,8 +257,8 @@ static int stm32_dmamux_probe(struct platform_device *pdev)
                return -ENODEV;
 
        iomem = devm_ioremap_resource(&pdev->dev, res);
-       if (!iomem)
-               return -ENOMEM;
+       if (IS_ERR(iomem))
+               return PTR_ERR(iomem);
 
        spin_lock_init(&stm32_dmamux->lock);