]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
gpiolib: convert to use DEFINE_SEQ_ATTRIBUTE macro
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 10 Sep 2020 10:19:35 +0000 (13:19 +0300)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 11 Sep 2020 15:33:51 +0000 (17:33 +0200)
Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpiolib.c

index 80137c1b3cdc10fa1686f6c1c6ee83871fdd05f8..1300650dc3084178a37df9be94080e29095f0c95 100644 (file)
@@ -4402,31 +4402,18 @@ static int gpiolib_seq_show(struct seq_file *s, void *v)
        return 0;
 }
 
-static const struct seq_operations gpiolib_seq_ops = {
+static const struct seq_operations gpiolib_sops = {
        .start = gpiolib_seq_start,
        .next = gpiolib_seq_next,
        .stop = gpiolib_seq_stop,
        .show = gpiolib_seq_show,
 };
-
-static int gpiolib_open(struct inode *inode, struct file *file)
-{
-       return seq_open(file, &gpiolib_seq_ops);
-}
-
-static const struct file_operations gpiolib_operations = {
-       .owner          = THIS_MODULE,
-       .open           = gpiolib_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = seq_release,
-};
+DEFINE_SEQ_ATTRIBUTE(gpiolib);
 
 static int __init gpiolib_debugfs_init(void)
 {
        /* /sys/kernel/debug/gpio */
-       debugfs_create_file("gpio", S_IFREG | S_IRUGO, NULL, NULL,
-                           &gpiolib_operations);
+       debugfs_create_file("gpio", 0444, NULL, NULL, &gpiolib_fops);
        return 0;
 }
 subsys_initcall(gpiolib_debugfs_init);