]> git.proxmox.com Git - mirror_qemu.git/commitdiff
test-qga: fix a resource leak in test_qga_guest_get_osinfo()
authorAlex Chen <alex.chen@huawei.com>
Wed, 25 Nov 2020 10:24:03 +0000 (10:24 +0000)
committerThomas Huth <thuth@redhat.com>
Wed, 9 Dec 2020 07:04:34 +0000 (08:04 +0100)
The fixture->fd is created in fixture_setup() and, likewise, needs to be closed
in fixture_tear_down().

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20201125102403.57709-1-alex.chen@huawei.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/test-qga.c

index c1b173b3cb21bc5bd939f870ee6bc1cfea0db850..eb33264e8ed3849b227f5d5817aa7eddd2185ff8 100644 (file)
@@ -111,6 +111,7 @@ fixture_tear_down(TestFixture *fixture, gconstpointer data)
 
     g_rmdir(fixture->test_dir);
     g_free(fixture->test_dir);
+    close(fixture->fd);
 }
 
 static void qmp_assertion_message_error(const char     *domain,