]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
null_blk: do not fail the module load with zero devices
authorAndré Almeida <andrealmeid@collabora.com>
Mon, 16 Sep 2019 14:07:57 +0000 (11:07 -0300)
committerJens Axboe <axboe@kernel.dk>
Mon, 16 Sep 2019 14:38:26 +0000 (08:38 -0600)
The module load should fail only if there is something wrong with the
configuration or if an error prevents it to work properly. The module
should be able to be loaded with (nr_device == 0), since it will not
trigger errors or be in malfunction state. Preventing loading with zero
devices also breaks applications that configures this module using
configfs API. Remove the nr_device check to fix this.

Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: André Almeida <andrealmeid@collabora.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk_main.c

index 53d4c15299844f52416eb5300fc86f810ea72ff7..909154b73b8a4df7fd312d8ca8bb0defd0cd023d 100644 (file)
@@ -1767,10 +1767,6 @@ static int __init null_init(void)
                pr_err("null_blk: legacy IO path no longer available\n");
                return -EINVAL;
        }
-       if (!nr_devices) {
-               pr_err("null_blk: invalid number of devices\n");
-               return -EINVAL;
-       }
        if (g_queue_mode == NULL_Q_MQ && g_use_per_node_hctx) {
                if (g_submit_queues != nr_online_nodes) {
                        pr_warn("null_blk: submit_queues param is set to %u.\n",