perf test: Convert clang tests to test cases.

Use null terminated array of test cases rather than the previous sub
test functions.

Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: Daniel Latypov <dlatypov@google.com>
Cc: David Gow <davidgow@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20211104064208.3156807-13-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/tests/clang.c b/tools/perf/tests/clang.c
index a499fcf37bf94c972f157664170603b12fbf17fe..ba06a2257574395c3a085f1b2a9d82dd4776cd23 100644 (file)
--- a/tools/perf/tests/clang.c
+++ b/tools/perf/tests/clang.c
@@ -3,54 +3,31 @@
 #include "c++/clang-c.h"
 #include <linux/kernel.h>
 
-static struct {
-       int (*func)(void);
-       const char *desc;
-} clang_testcase_table[] = {
-#ifdef HAVE_LIBCLANGLLVM_SUPPORT
-       {
-               .func = test__clang_to_IR,
-               .desc = "builtin clang compile C source to IR",
-       },
-       {
-               .func = test__clang_to_obj,
-               .desc = "builtin clang compile C source to ELF object",
-       },
-#endif
-};
-
-static int test__clang_subtest_get_nr(void)
-{
-       return (int)ARRAY_SIZE(clang_testcase_table);
-}
-
-static const char *test__clang_subtest_get_desc(int i)
-{
-       if (i < 0 || i >= (int)ARRAY_SIZE(clang_testcase_table))
-               return NULL;
-       return clang_testcase_table[i].desc;
-}
-
 #ifndef HAVE_LIBCLANGLLVM_SUPPORT
-static int test__clang(struct test_suite *test __maybe_unused, int i __maybe_unused)
+static int test__clang_to_IR(struct test_suite *test __maybe_unused,
+                            int subtest __maybe_unused)
 {
        return TEST_SKIP;
 }
-#else
-static int test__clang(struct test_suite *test __maybe_unused, int i)
+
+static int test__clang_to_obj(struct test_suite *test __maybe_unused,
+                             int subtest __maybe_unused)
 {
-       if (i < 0 || i >= (int)ARRAY_SIZE(clang_testcase_table))
-               return TEST_FAIL;
-       return clang_testcase_table[i].func();
+       return TEST_SKIP;
 }
 #endif
 
+static struct test_case clang_tests[] = {
+       TEST_CASE_REASON("builtin clang compile C source to IR", clang_to_IR,
+                        "not compiled in"),
+       TEST_CASE_REASON("builtin clang compile C source to ELF object",
+                        clang_to_obj,
+                        "not compiled in"),
+       { .name = NULL, }
+};
+
 struct test_suite suite__clang = {
        .desc = "builtin clang support",
-       .func = test__clang,
-       .subtest = {
-               .skip_if_fail   = true,
-               .get_nr         = test__clang_subtest_get_nr,
-               .get_desc       = test__clang_subtest_get_desc,
-       }
+       .test_cases = clang_tests,
+       .subtest = { .skip_if_fail = true, },
 };

diff --git a/tools/perf/util/c++/clang-c.h b/tools/perf/util/c++/clang-c.h
index 2df8a45bd0888f17a9a22d0d4002ebce83420d1e..d3731a876b6c10c58a91b66835e33776486525d8 100644 (file)
--- a/tools/perf/util/c++/clang-c.h
+++ b/tools/perf/util/c++/clang-c.h
@@ -12,8 +12,9 @@ extern "C" {
 extern void perf_clang__init(void);
 extern void perf_clang__cleanup(void);
 
-extern int test__clang_to_IR(void);
-extern int test__clang_to_obj(void);
+struct test_suite;
+extern int test__clang_to_IR(struct test_suite *test, int subtest);
+extern int test__clang_to_obj(struct test_suite *test, int subtest);
 
 extern int perf_clang__compile_bpf(const char *filename,
                                   void **p_obj_buf,
@@ -26,9 +27,6 @@ extern int perf_clang__compile_bpf(const char *filename,
 static inline void perf_clang__init(void) { }
 static inline void perf_clang__cleanup(void) { }
 
-static inline int test__clang_to_IR(void) { return -1; }
-static inline int test__clang_to_obj(void) { return -1;}
-
 static inline int
 perf_clang__compile_bpf(const char *filename __maybe_unused,
                        void **p_obj_buf __maybe_unused,

diff --git a/tools/perf/util/c++/clang-test.cpp b/tools/perf/util/c++/clang-test.cpp
index 21b23605f78b74349994c5782884d4d23ca4f5f9..a4683ca536973c04cf2ffe4cdb0efbc1811bae2c 100644 (file)
--- a/tools/perf/util/c++/clang-test.cpp
+++ b/tools/perf/util/c++/clang-test.cpp
@@ -35,7 +35,8 @@ __test__clang_to_IR(void)
 }
 
 extern "C" {
-int test__clang_to_IR(void)
+int test__clang_to_IR(struct test_suite *test __maybe_unused,
+                      int subtest __maybe_unused)
 {
        perf_clang_scope _scope;
 
@@ -48,7 +49,8 @@ int test__clang_to_IR(void)
        return -1;
 }
 
-int test__clang_to_obj(void)
+int test__clang_to_obj(struct test_suite *test __maybe_unused,
+                       int subtest __maybe_unused)
 {
        perf_clang_scope _scope;