]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
pwm: tiehrpwm: Handle deferred probe with dev_err_probe()
authorGrygorii Strashko <grygorii.strashko@ti.com>
Fri, 30 Oct 2020 20:12:54 +0000 (22:12 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 17 Dec 2020 13:18:49 +0000 (14:18 +0100)
The devm_clk_get() may return -EPROBE_DEFER which is not handled properly
by TI EHRPWM driver and causes unnecessary boot log messages.

Hence, add proper deferred probe handling with new dev_err_probe() API.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-tiehrpwm.c

index 97dc62fe91753550e5a9fa12ca0e1840fb63ecf0..a7fb224d65350cf054111ba547a99144924751fc 100644 (file)
@@ -436,10 +436,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
                }
        }
 
-       if (IS_ERR(clk)) {
-               dev_err(&pdev->dev, "failed to get clock\n");
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(clk), "Failed to get fck\n");
 
        pc->clk_rate = clk_get_rate(clk);
        if (!pc->clk_rate) {
@@ -460,10 +458,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
 
        /* Acquire tbclk for Time Base EHRPWM submodule */
        pc->tbclk = devm_clk_get(&pdev->dev, "tbclk");
-       if (IS_ERR(pc->tbclk)) {
-               dev_err(&pdev->dev, "Failed to get tbclk\n");
-               return PTR_ERR(pc->tbclk);
-       }
+       if (IS_ERR(pc->tbclk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(pc->tbclk), "Failed to get tbclk\n");
 
        ret = clk_prepare(pc->tbclk);
        if (ret < 0) {