]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net/mlx5e: Align RX/TX reporters diagnose output format
authorAya Levin <ayal@mellanox.com>
Thu, 30 Apr 2020 09:18:22 +0000 (12:18 +0300)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 3 Jul 2020 04:05:17 +0000 (21:05 -0700)
Change the hierarchy of the RX reporter 'Common config' in the diagnose
output to match the 'Common config' of the TX reporter which reflects
that CQ is a helper to the traffic queues.

Before:
$ devlink health diagnose pci/0000:00:0b.0 reporter rx
Common config:
    RQ:
      type: 2 stride size: 2048 size: 8
    CQ:
      stride size: 64 size: 1024
    RQs:
    ...

After:
$ devlink health diagnose pci/0000:00:0b.0 reporter rx
Common config:
    RQ:
      type: 2 stride size: 2048 size: 8
      CQ:
        stride size: 64 size: 1024
    RQs:
    ...

Signed-off-by: Aya Levin <ayal@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c

index b8b32aef136371770f8c3926433a1ef654be8cf5..f1edde1ab8bc6454f4b737994ac081e608b10051 100644 (file)
@@ -284,11 +284,11 @@ static int mlx5e_rx_reporter_diagnose(struct devlink_health_reporter *reporter,
        if (err)
                goto unlock;
 
-       err = mlx5e_reporter_named_obj_nest_end(fmsg);
+       err = mlx5e_reporter_cq_common_diagnose(&generic_rq->cq, fmsg);
        if (err)
                goto unlock;
 
-       err = mlx5e_reporter_cq_common_diagnose(&generic_rq->cq, fmsg);
+       err = mlx5e_reporter_named_obj_nest_end(fmsg);
        if (err)
                goto unlock;