]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/timer/sh_timer: Remove superfluous "break" statements
authorThomas Huth <thuth@redhat.com>
Tue, 20 Oct 2020 15:39:35 +0000 (17:39 +0200)
committerPhilippe Mathieu-Daudé <f4bug@amsat.org>
Mon, 26 Oct 2020 23:22:56 +0000 (00:22 +0100)
hw_error() is marked as QEMU_NORETURN, so the "break" statements
after this function are just dead code.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201020153935.54315-4-thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
hw/timer/sh_timer.c

index 934daaa7dcc9e5f9202f5c2db06a7ffced28ef63..58af1a1edbdc9db3981173ae331cd97357da1279 100644 (file)
@@ -125,7 +125,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
             /* fallthrough */
         default:
             hw_error("sh_timer_write: Reserved TPSC value\n");
-            break;
         }
         switch ((value & TIMER_TCR_CKEG) >> 3) {
         case 0:
@@ -139,7 +138,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
             /* fallthrough */
         default:
             hw_error("sh_timer_write: Reserved CKEG value\n");
-            break;
         }
         switch ((value & TIMER_TCR_ICPE) >> 6) {
         case 0:
@@ -152,7 +150,6 @@ static void sh_timer_write(void *opaque, hwaddr offset,
             /* fallthrough */
         default:
             hw_error("sh_timer_write: Reserved ICPE value\n");
-            break;
         }
         if ((value & TIMER_TCR_UNF) == 0) {
             s->int_level = 0;